Add maintainer onboarding and release guidance - #1529
Merged
bmehta001 merged 9 commits intoSep 24, 2026
Merged
Conversation
Centralize build, validation, PR, and release practices so maintainers can follow one current operational guide. Files changed: - README.md - docs/maintainer-onboarding.md - docs/versioning.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a7d76f00-9675-4f19-9639-118e0d3dab4e
Avoid overstating Mac Catalyst and visionOS support while documenting the SPM xcframework slices available for evaluation. Files changed: - README.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a7d76f00-9675-4f19-9639-118e0d3dab4e
docs/maintainer-onboarding.md: guide maintainers to review non-gating leak warnings and avoid unsupported Windows compatibility work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Baiju Meswani (baijumeswani)
left a comment
Baiju Meswani (baijumeswani)
left a comment
Contributor
There was a problem hiding this comment.
The guide is useful and most commands match the repository. I found three documentation issues that should be corrected before approval.
Make tools/gen-version.sh run relative to its script directory so documented root invocations work. Clarify the SPM X.Y.Z collision for fourth-component-only corrections in docs/maintainer-onboarding.md and docs/versioning.md; verified against .github/workflows/spm-release.yml. The leak-workflow link already resolves in the merged main at a387a25; no separate fix is needed. Files changed: tools/gen-version.sh, docs/maintainer-onboarding.md, docs/versioning.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bmehta001
enabled auto-merge (squash)
September 24, 2026 07:23
Move the wrapped configuration from file scope to a per-instance owning pointer, preventing later copies from redirecting earlier wrappers and leaking prior allocations. Files: wrappers/obj-c/ODWLogConfiguration.mm, wrappers/obj-c/ODWLogConfiguration_private.h, tests/unittests/obj-c/ODWLogConfigurationTests.mm Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a668528d-5dc9-4648-a753-95c0235cc103
Check presence through HasConfig rather than converting an unset Variant to a string; this preserves the regression assertion without crashing debug iOS tests. Files: tests/unittests/obj-c/ODWLogConfigurationTests.mm Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a668528d-5dc9-4648-a753-95c0235cc103
…o bhamehta/maintainer-onboarding-guide
This was referenced Sep 24, 2026
Baiju Meswani (baijumeswani)
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
misspellchecker on all changed Markdown filesgit diff --check